This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Fix FrameworkController broken change#628
Merged
yds05 merged 46 commits intomicrosoft:masterfrom Jan 22, 2019
Merged
Conversation
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
…rameworkcontroller-distributed
merge master
yqwang-ms
approved these changes
Jan 18, 2019
yqwang-ms
reviewed
Jan 21, 2019
| portScript += `FB_${taskRole.name.toUpperCase()}_PORT=${this.fcContainerPortMap.get(taskRole.name)} `; | ||
| } | ||
| return `${portScript} . /mnt/frameworkbarrier/injector.sh && ${command}`; | ||
| // return `${portScript} . /mnt/frameworkbarrier/injector.sh && ${command}`; |
Contributor
Author
There was a problem hiding this comment.
Sorry, misoperation.
Member
There was a problem hiding this comment.
NP, please test before merge :)
yqwang-ms
approved these changes
Jan 21, 2019
yds05
approved these changes
Jan 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.Frameworkcontroller has updated recently, microsoft/frameworkcontroller#6, nni need to update related environment variables.
2.Support serviceAccountName spec for FrameworkController.