FEAT: Replace bulkcopy kwargs with explicit parameters

[bewithgaurav]

Work Item / Issue Reference

AB#41884

GitHub Issue: #<ISSUE_NUMBER>

---

Summary

This pull request refactors the _bulkcopy method in mssql_python/cursor.py to improve its interface and documentation. Instead of accepting arbitrary keyword arguments, the method now explicitly declares all supported bulk copy options as named parameters with type hints and default values.

[Copilot]

Pull request overview

Refactors Cursor._bulkcopy to replace **kwargs bulk-copy options with an explicit, type-hinted parameter list and updated docstring.

Changes:

• Replaced **kwargs in _bulkcopy with explicit parameters (e.g., batch_size, timeout, column_mappings, and bulk-copy flags).
• Expanded _bulkcopy docstring to document supported bulk copy options.
• Updated the pycore_cursor.bulkcopy(...) invocation to pass the new explicit parameters.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The doc/type for column_mappings now allows a string “source column name”, but the data contract above still says each row is a tuple/list (which has no column names). Please clarify the supported row types and mapping behavior, or restrict column_mappings back to index-based mapping to avoid misleading API/docs.

Suggested change

	- source: Column name (str) or 0-based index (int) in the source data
	- source: 0-based index (int) in the source data

[Copilot]

The refactor changes behavior by always passing parameters like keep_identity, check_constraints, etc. to pycore_cursor.bulkcopy, even when they are None. Previously, omitted options would not be forwarded at all (via **kwargs), allowing the underlying library defaults to apply. To preserve semantics (and avoid potential TypeError if the core API expects bool), build a kwargs/options dict and only include values that are not None (or change defaults to explicit booleans).

Suggested change

	result = pycore_cursor.bulkcopy(
	table_name,
	iter(data),
	batch_size=batch_size,
	timeout=timeout,
	column_mappings=column_mappings,
	keep_identity=keep_identity,
	check_constraints=check_constraints,
	table_lock=table_lock,
	keep_nulls=keep_nulls,
	fire_triggers=fire_triggers,
	use_internal_transaction=use_internal_transaction,
	bulkcopy_kwargs = {}
	if batch_size is not None:
	bulkcopy_kwargs["batch_size"] = batch_size
	if timeout is not None:
	bulkcopy_kwargs["timeout"] = timeout
	if column_mappings is not None:
	bulkcopy_kwargs["column_mappings"] = column_mappings
	if keep_identity is not None:
	bulkcopy_kwargs["keep_identity"] = keep_identity
	if check_constraints is not None:
	bulkcopy_kwargs["check_constraints"] = check_constraints
	if table_lock is not None:
	bulkcopy_kwargs["table_lock"] = table_lock
	if keep_nulls is not None:
	bulkcopy_kwargs["keep_nulls"] = keep_nulls
	if fire_triggers is not None:
	bulkcopy_kwargs["fire_triggers"] = fire_triggers
	if use_internal_transaction is not None:
	bulkcopy_kwargs["use_internal_transaction"] = use_internal_transaction
	result = pycore_cursor.bulkcopy(
	table_name,
	iter(data),
	**bulkcopy_kwargs,

[bewithgaurav]

we're sending appropriate params, resolving this

[Copilot]

batch_size is typed as Optional[int], but the validation accepts floats (isinstance(batch_size, (int, float))) while the error message says “positive integer”. Please align the type hint, validation, and message (either require an int, or explicitly support non-integer values and document why).

Suggested change

	batch_size: Optional[int] = None,
	batch_size: Optional[Union[int, float]] = None,