Add more caching tests and remove no-op stats in LocalCacheProvider#1087
Merged
ecraig12345 merged 7 commits intomicrosoft:mainfrom Apr 1, 2026
Merged
Add more caching tests and remove no-op stats in LocalCacheProvider#1087ecraig12345 merged 7 commits intomicrosoft:mainfrom
ecraig12345 merged 7 commits intomicrosoft:mainfrom
Conversation
9cc30f5 to
6869144
Compare
christiango
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more tests for the cache storage providers to prevent future issues such as the one fixed by #1083. This includes tests for the Azure provider (which wasn't covered at all previously) with a mock container client.
While looking at this, I discovered a previous change 5 years ago had attempted to optimize
LocalCacheStoragerestoration by not copying files that weren't modified. Problem is it tried to filter withfiles.filter(async ...)which will always return a promise, which is truthy--so it was just adding extrastatoperations for no reason. See file comment for more discussion, but for now the safest approach is just to remove this check and save onstatcalls.Also while debugging this, I found that the
jestSetupAfterEnvwas callingjest.resetModules()inbeforeEachas a bad workaround for clearing environment variables and their side effects (see #413)... I updated it to instead clearLAGE_andBACKFILL_env vars once on startup.