Conditional Breakpoint got error code in reply:504#453
Merged
testforstephen merged 1 commit intomicrosoft:mainfrom Oct 31, 2022
Merged
Conditional Breakpoint got error code in reply:504#453testforstephen merged 1 commit intomicrosoft:mainfrom
testforstephen merged 1 commit intomicrosoft:mainfrom
Conversation
jdneo
approved these changes
Oct 31, 2022
Eskibear
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-java-debug#1250
In old behavior, conditional breakpoint will store some stale stackframes in the cache so that its length doesn't match the new conditional breakpoint's stackframe length.
Fix: conditional breakpoint doesn't need to reload the stack frames if the thread's stackframes are not used before.