Pass attempt label to JUnit output to distinguish test retries#2209
Merged
michelle-clayton-work merged 9 commits intomicrosoft/mainfrom Apr 4, 2026
Merged
Pass attempt label to JUnit output to distinguish test retries#2209michelle-clayton-work merged 9 commits intomicrosoft/mainfrom
michelle-clayton-work merged 9 commits intomicrosoft/mainfrom
Conversation
dagood
reviewed
Mar 24, 2026
4d6827e to
ea7101d
Compare
Member
GitHub quirk: if you put this in a list (without changing anything else), GitHub grabs the issue title. I do this basically always--more immediately readable and makes it obvious when I've grabbed the wrong issue.
|
e5e2a77 to
37c661c
Compare
37c661c to
6b8ae68
Compare
Contributor
Author
|
6b8ae68 to
e4aaf43
Compare
Add -attempt and -jobattempt flags to run-builder, passed through to json2junit. This distinguishes test results along two retry dimensions: - System.JobAttempt (AzDO job-level rerun): passed as -jobattempt - retryAttempts loop (in-job test retry): passed as -attempt All retry attempts are published in a single test run with title: 'linux-amd64 test (ubuntu) (job attempt 2)' Suite names inside the XML distinguish retries: 'cmd/go [job attempt 2, retry 3]' Includes a temporary forced flake on attempt 1 for testing retry visibility (marked with TODO for removal). Fixes: #2134
e9de3e8 to
d4760ed
Compare
d4760ed to
1ccccbc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Azure DevOps test result reporting for retried test runs by ensuring each retry produces distinct JUnit output and by passing a CI attempt label through to the JUnit converter (via updated go-infra support).
Changes:
- Emit per-retry JUnit XML files (
TestResults-attempt-*.xml) and publish them via wildcard. - Pass a CI attempt label (
-jobattempt, currently wired to$(System.StageAttempt)) throughrun-builderintojson2junitoptions. - Bump
github.com/microsoft/go-infradependency to pick up Attempt/JobAttempt support injson2junit.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/pipeline/stages/run-stage.yml | Write unique JUnit XML per retry attempt; publish all attempt files; pass CI attempt label; adjust artifact naming/title. |
| eng/_util/buildutil/testjson.go | Add -jobattempt flag and forward it into json2junit options. |
| eng/_util/go.mod | Update go-infra dependency version. |
| eng/_util/go.sum | Update go-infra checksums for the new version. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp help |
Supported commands
See additional documentation. |
Contributor
Author
|
/azp where |
|
Azure DevOps orgs getting events for this repository: |
dagood
reviewed
Apr 2, 2026
Member
dagood
left a comment
There was a problem hiding this comment.
Do you have a test run with a simulated failure showing what job/stage attempts look like with this change? I'm not quite sure how it'll show up, and why/when to use jobattempt vs. testRunTitle.
e9e14f9 to
da97858
Compare
da97858 to
01314bc
Compare
7914c07 to
90db8ad
Compare
dagood
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup PR to microsoft/go-infra#449
This ensures test result entries in AzDO distinguish which attempt they correspond to, both via unique file names and via the attempt label embedded in JUnit test suite names.
Fixes: #2134