[DO NOT MERGE] Hotfix candidate: disable sparse index#452
Closed
derrickstolee wants to merge 2 commits intovfs-2.33.0from
Closed
[DO NOT MERGE] Hotfix candidate: disable sparse index#452derrickstolee wants to merge 2 commits intovfs-2.33.0from
derrickstolee wants to merge 2 commits intovfs-2.33.0from
Conversation
This reverts commit f55843a. We are disabling the sparse index by default so we can take the latest changes from the vfs-2.33.0 branch and cut a new release that should help users affected by #450 (slow commands due to getting an environment variable). This commit represents an approach that would include shipping the latest FS Monitor feature in addition to other installer fixes. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho
approved these changes
Oct 19, 2021
Member
dscho
left a comment
There was a problem hiding this comment.
Thank you for spelling out the risks and benefits. I am convinced that the risks are small, and that we would be able to react quickly in case of a critical bug, anyway.
Author
|
These changes are included in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of two possible hotfixes for the performance issue in v2.33.0.vfs.0.0 due to #450.
This takes our latest vfs-2.33.0 branch and reverts #414, so we are not shipping the sparse index prematurely.
It does have these benefits:
It also has some risks:
I'm less concerned about these risks because we have some confidence in the bug bash release, v2.33.0.vfs.0.2.