sparse-index: introduce GIT_TEST_FAIL_ENSURE_FULL_INDEX#420
sparse-index: introduce GIT_TEST_FAIL_ENSURE_FULL_INDEX#420derrickstolee wants to merge 1 commit intomicrosoft:vfs-2.33.0from
Conversation
To be extra sure that our integrated commands do not expand in normal cases, create a GIT_TEST_FAIL_ENSURE_FULL_INDEX that fails inside ensure_full_index() if the repo settings indicate we are in an integrated command. Enable this for the Scalar functional tests. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
|
This is functioning as expected, and gives me some directions to investigate. It is possible/probable that we are testing scenarios in the Scalar functional tests that require expanding the index. If not, then it gives directions for future improvement. (The first failure I saw involved |
dscho
left a comment
There was a problem hiding this comment.
I am really glad that my suggestion was worth the time to implement it!
|
After digging into it, it appears that this is failing during a |
To be extra sure that our integrated commands do not expand in normal
cases, create a GIT_TEST_FAIL_ENSURE_FULL_INDEX that fails inside
ensure_full_index() if the repo settings indicate we are in an
integrated command. Enable this for the Scalar functional tests.
Inspired by a conversation with @dscho.