Fix symbol-publish gate in build-all-lib.yml to use a branch allowlist

[tlmii]

Pull Request

📖 Description

Follow-up to #4910, which added internal symbol publishing to the two CI pipelines.

In eng/pipelines/build-all-lib.yml, the two symbol-publishing template invocations were gated on:

and(succeeded(), startsWith(variables['Build.SourceBranch'], 'refs/tags/v'))

The pipeline's declared trigger looks tag-based (tags: include: v*), but in practice this pipeline is always queued manually against a release branch HEAD (e.g. after tagging) rather than via a tag push. As a result the refs/tags/v* condition never evaluated true and symbols were never actually published from this pipeline.

This change switches both conditions to the branch allowlist already used successfully by eng/pipelines/build-core-lib.yml (main / dev / dev-v5 / archives/*), OR-ing in the refs/tags/v* check so the declared tag-trigger path stays covered:

and(succeeded(), or(in(variables['Build.SourceBranch'], 'refs/heads/main', 'refs/heads/dev', 'refs/heads/dev-v5'), startsWith(variables['Build.SourceBranch'], 'refs/heads/archives/'), startsWith(variables['Build.SourceBranch'], 'refs/tags/v')))

The stale inline comment that claimed the gate existed to prevent manual branch queues from uploading (the opposite of the desired behavior) was updated to match.

🎫 Issues

Follow-up to #4910.

👩‍💻 Reviewer Notes

Surgical change — only the two conditions and one comment in build-all-lib.yml are touched. build-core-lib.yml, publish-symbols-stage.yml, and publish-symbols-upload.yml are unchanged. The new condition is intentionally identical to the one in build-core-lib.yml (plus the tag check).

📑 Test Plan

No code changes; CI pipeline YAML only. The pipeline is internal and cannot be exercised from this PR. The conditions were verified to match build-core-lib.yml's working gate.

✅ Checklist

General

• I have added tests for my changes.
• I have tested my changes.
• I have updated the project documentation to reflect my changes.
• I have read the CONTRIBUTING documentation and followed the standards for this project.

  _{Generated via Copilot (Claude Opus 4.8) on behalf of @tlmii}

[Copilot]

Pull request overview

This PR fixes the internal symbol-publishing gate in eng/pipelines/build-all-lib.yml so it works when the pipeline is manually queued against a release branch HEAD (the practical release workflow), while still keeping the declared tag-trigger path covered.

Changes:

• Updated the publish-symbols-stage.yml and publish-symbols-upload.yml invocation conditions to use the same branch allowlist as build-core-lib.yml, plus an additional refs/tags/v* check.
• Updated the inline comment above the staging template invocation to reflect the real queuing behavior and the new gating rationale.

Show a summary per file

File	Description
eng/pipelines/build-all-lib.yml	Adjusts symbol publish conditions to allow manual release-branch runs (branch allowlist) while retaining tag-trigger coverage, and updates the related comment.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0

[vnbaaij]

Do we need to release a new v4 version to make the symbols appear? Or can it be triggered manually?
New version is not ideal but also not impossible to do. It will probably be a while before we do another v4 release.