You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace item?.Tostring() to determine current selected value as this would result in NamespaceName.MyClass for most cases.
Now uses a hash key as the default and not the GetHashCode for security.
Give me a few days to verify these changes. One initial note: You cannot change the unit tests. If that is required, it is a breaking change.
No rush at all 😊
You’re right that changing tests typically implies a breaking change, but in this case, most of the tests I updated were either checking ToString() outputs or performing *.verified.razor.html comparisons with hardcoded option values. So while it could be a breaking change, I’d expect it to only affect very specific edge cases.
I’m also happy to discuss this further over a Teams call if that would help.
Just realized something, when working with a list of strings the reference will be different while the value might be the same.
I need to address that issue first. So i marked the pr as draft again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Replace
item?.Tostring()to determine current selected value as this would result inNamespaceName.MyClassfor most cases.Now uses a hash key as the default and not the
GetHashCodefor security.🎫 Issues
Fix #4128
✅ Checklist
General
Component-specific