Make the ICU SONAME configurable#495
Merged
Merged
Conversation
lhecker
force-pushed
the
dev/lhecker/linux-icu-soname
branch
from
June 18, 2025 14:35
a36f3d6 to
e6aad7c
Compare
DHowett
reviewed
Jun 19, 2025
| This project _optionally_ depends on the ICU library for its Search and Replace functionality. | ||
| By default, the project will look for a SONAME without version suffix: | ||
| * Windows: `icuuc.dll` | ||
| * macOS: `libicuuc.dylib` |
Member
There was a problem hiding this comment.
I think macOS only has libicucore, and not uc/i18n... hmm
Member
Author
There was a problem hiding this comment.
I think it also exports all of them as C++ symbols, i.e. with underscore prefix.
DHowett
approved these changes
Jun 19, 2025
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This PR was tested on Ubuntu with: ``` EDIT_CFG_ICUUC_SONAME=libicuuc.so.74 EDIT_CFG_ICUI18N_SONAME=libicui18n.so.74 EDIT_CFG_ICU_RENAMING_VERSION=74 cargo build --config .cargo/release.toml --release ``` Search & Replace now works flawlessly. I hope that package maintainers will be able to make use of this when ingesting future versions of Edit. Closes microsoft#172
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was tested on Ubuntu with:
Search & Replace now works flawlessly. I hope that package maintainers
will be able to make use of this when ingesting future versions of Edit.
Closes #172