Skip to content

Remove redundant heap allocation in DisplayablePathBuf::from_string #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DHowett merged 4 commits into from
Jun 4, 2025
Merged

Remove redundant heap allocation in DisplayablePathBuf::from_string #336

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ae9e4f
Remove redundant heap allocation in `DisplayablePathBuf::from_string`
rhysd May 28, 2025
a0ee9a5
Remove cost of scanning UTF-8 sequence in `DisplayablePathBuf::from_s…
rhysd May 30, 2025
d564694
Merge remote-tracking branch 'origin/main' into remove-redundant-heap…
lhecker May 30, 2025
e81a3d1
Allow us to drop the field name
lhecker May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/bin/edit/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@ pub struct DisplayablePathBuf {

impl DisplayablePathBuf {
#[allow(dead_code, reason = "only used on Windows")]
pub fn from_string(str: String) -> Self {
let value = PathBuf::from(&str);
Self { value, str: Cow::Owned(str) }
pub fn from_string(string: String) -> Self {
let str = Cow::Borrowed(string.as_str());
let str = unsafe { mem::transmute::<Cow<'_, str>, Cow<'_, str>>(str) };
let value = PathBuf::from(string);
Self { value, str }
}

pub fn from_path(value: PathBuf) -> Self {
Expand Down