Skip to content

Fix file picker entries not being sorted #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DHowett merged 1 commit into from
May 27, 2025
Merged

Fix file picker entries not being sorted #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/bin/edit/draw_filepicker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,11 @@ fn draw_file_picker_update_path(state: &mut State) -> Option<PathBuf> {
fn draw_dialog_saveas_refresh_files(state: &mut State) {
let dir = state.file_picker_pending_dir.as_path();
let mut files = Vec::new();
let mut off = 0;

if dir.parent().is_some() {
files.push(DisplayablePathBuf::from(".."));
off = 1;
}

if let Ok(iter) = fs::read_dir(dir) {
Expand All @@ -238,7 +240,6 @@ fn draw_dialog_saveas_refresh_files(state: &mut State) {
}

// Sort directories first, then by name, case-insensitive.
let off = files.len().saturating_sub(1);

@DHowett DHowett May 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

files[off..].sort_by(|a, b| {
let a = a.as_bytes();
let b = b.as_bytes();
Expand Down