Skip to content

Add shortcut button functionality to tui context#275

Closed
brandochn wants to merge 2 commits into
microsoft:mainfrom
brandochn:feature/add-shorcut-button
Closed

Add shortcut button functionality to tui context#275
brandochn wants to merge 2 commits into
microsoft:mainfrom
brandochn:feature/add-shorcut-button

Conversation

@brandochn

Copy link
Copy Markdown

Hello Guys,

I was working on this issue #48 I have implemented a new shortcut button as in the comments mentioned.

image

shortcut_button

Please take at look on it and let me know what you guys think.

@brandochn

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@Ride-A-Pig

Ride-A-Pig commented May 26, 2025

Copy link
Copy Markdown
Contributor

I think the shortcut should just be S for save, N for discard and esc for cancel

@brandochn

Copy link
Copy Markdown
Author

@Ride-A-Pig

Done!

image

@lhecker

lhecker commented May 26, 2025

Copy link
Copy Markdown
Member

Thank you for your work! Unfortunately, someone submitted a conflicting PR yesterday: #276
Personally, I like the approach in #276 more. As such I must unfortunately close this PR. I genuinely apologize for this. 😢

@lhecker lhecker closed this May 26, 2025
@brandochn
brandochn deleted the feature/add-shorcut-button branch May 26, 2025 16:58
@brandochn
brandochn restored the feature/add-shorcut-button branch May 26, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants