Skip to content

feat: add Edit -> Select All action#212

Merged
lhecker merged 4 commits into
microsoft:mainfrom
ankddev:add-edit-selectall
May 27, 2025
Merged

feat: add Edit -> Select All action#212
lhecker merged 4 commits into
microsoft:mainfrom
ankddev:add-edit-selectall

Conversation

@ankddev

@ankddev ankddev commented May 22, 2025

Copy link
Copy Markdown
Contributor

Closes #211

Description

Add Select All action in Edit menu.

Screenshots

Comment thread src/bin/edit/localization.rs Outdated
Co-authored-by: Leonard Hecker <leonard@hecker.io>
@ankddev
ankddev requested a review from lhecker May 22, 2025 14:43

@lhecker lhecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait a bit before merging this as we have various conflicting translation PRs. I'm not 100% sure yet in what order to merge them and how. 😅

Comment thread src/bin/edit/draw_menubar.rs Outdated

@lhecker lhecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@lhecker
lhecker merged commit 97f8316 into microsoft:main May 27, 2025
@ankddev
ankddev deleted the add-edit-selectall branch May 27, 2025 12:01
/* ru */ "Выделить всё",
/* zh_hans */ "全选",
/* zh_hant */ "全選"
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please test your changes locally next time? This is missing a trailing comma and couldn't have possibly compiled for you. Don't worry about it though, I'll fix this in my next PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for that. Will check better next time. BTW, I runned it locally to take screenshot, don't know how it compiled. Maybe I changed something after this. 🤔

Lou32Verbose pushed a commit to Lou32Verbose/edit that referenced this pull request Jan 11, 2026
Closes microsoft#211

Co-authored-by: Leonard Hecker <leonard@hecker.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add Edit > Select All action

3 participants