Skip to content

feat(assets): add a .desktop entry #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MingcongBai wants to merge 1 commit into from
Closed

feat(assets): add a .desktop entry #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions assets/com.microsoft.edit.desktop
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
[Desktop Entry]
Type=Application
Name=Edit
Name[zh_CN]=编辑器
GenericName=Text Editor
GenericName[zh_CN]=文本编辑器
GenericName[zh_TW]=文字編輯器
Comment=A simple editor for simple needs
Comment[zh_CN]=用于简单编辑需要的简易编辑器
Icon=edit
Exec=edit %U
Terminal=true
MimeType=text/plain;
Keywords=text;txt;editor;note;notepad;
Keywords[zh_CN]=text;txt;editor;note;notepad;文字;文本;编辑器;笔记;记事本;wenzi;wenben;bianjiqi;biji;jishiben;
Comment on lines +14 to +15

@lhecker lhecker May 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helix only lists "text" and "editor" as keywords: https://github.com/helix-editor/helix/blob/3a6c9747b8de3350c38ba504916233d9d4c33c5c/contrib/Helix.desktop#L82
Should we do the same and only use this?

Keywords=text;editor

@MingcongBai MingcongBai May 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same and only use this?

This was done to align with KWrite, which in my opinion is quite easy to search for - being able to find it with "Windows-like" keywords is convenient.

@driver1998 driver1998 May 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit and Notepad are two very different things, even on Windows.
I don't think people expect searching for "记事本" (Notepad) and getting a TUI editor...

@MingcongBai MingcongBai May 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit and Notepad are two very different things, even on Windows. I don't think people expect searching for "记事本" (Notepad) and getting a TUI editor...

Sure, but notepad.exe and wordpad.exe being different things are really beside the point - both KDE and GNOME relies heavily on search-based navigation, and so does more traditional desktop environments (more experienced users are more likely to just use Alt-F2), same goes for WMs.

The second point I can agree with, but then this .desktop entry is useless - "why wouldn't they just run edit in a terminal?"

@MingcongBai MingcongBai May 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, to clarify, I do not expect everyone to install or package this .desktop entry, it's here as a reference.

@lhecker lhecker May 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed this and would currently prefer just text;editor like Helix uses. Could you make this change? If we ever take on more complex features (like VS Code) we could extend the list.