Error when opening files on shares (including WSL)

[stanyip85]

Enumerating files is fine, opening files not.
Tested files in following environments (Connecting from Windows 10):

1. Samba on Mac/Linux - Failed
2. Windows Server 2012 - OK
3. Windows 7 - Failed
4. Windows 10 - OK

Failed one returns 0x80070057: The parameter is correct
Opening with other programs (including notepad) work fine.

[DHowett]

Ah, I wonder if it is because we use File IDs for deduplication. If the filesystem doesn't support them, we need a fallback.

[lhecker]

That this happens on multiple types of shares probably confirms that this is due to the file ID. Relevant code:

edit/src/bin/edit/documents.rs

Lines 153 to 162 in d832058

	let mut file = match Self::open_for_reading(&path) {
	Ok(file) => Some(file),
	Err(err) if sys::apperr_is_not_found(err) => None,
	Err(err) => return Err(err),
	};
	let file_id = match &file {
	Some(file) => Some(sys::file_id(file)?),
	None => None,
	};

Not sure what to use as an alternative. Perhaps we could use std::fs::canonicalize and turn the FileId into an enum with either an ID or a PathBuf as fallback?

[DHowett]

I was just working on this one too :D