Add a settings page

[lhecker]

Over time, more and more things may want to be configurable. Today it's:

• Theme colors
• Changing keyboard bindings
• Setting the ruler column for COMMIT_EDITMSG and others
• Enabling/Disabling the margin (line numbers)
• Enabling word-wrap for certain file types
• Cursor style
• Application language

We should use TOML, because JSON is kind of meh. It's also used by Helix.

On top of adding the mere dialog, this feature requires implementing settings persistence. This would mean:

• Windows: A settings file
  • BUT: There are concerns about this making GPO more difficult. This needs to be watertight before we ship it.
• Linux: XDG ~/.config directory - maybe as a JSON file?
  • Implementing a JSON parser by hand would be funny
• macOS: Settings file but not sure which path ❔

[stianhoiland]

More wanted options:

• Exit after closing last editor
• Show/Hide statusbar (should be in View menu)
• Persistent "Use spaces or tabs" (this one is driving me crazy!)
• Show/Hide menu (pressing Alt hotkeys should temporarily show menu again)
• Enable/Disable overscroll aka. "scroll past last line"
• Enable/Disable current line highlighting

[eamonburns]

My 2¢ on settings persistence on Windows:

Having the settings stored in the registry would be very annoying. Being able to copy (or use source control on) a single settings.json file would be very nice. In that case, you could pretty much have the same settings persistence scheme for all OS's (only difference would be file location).

Windows Terminal does this.

Having a settings file could also help with deficiencies in the settings editor. For example, in Windows Terminal, there is not a way to re-order profiles using the GUI, but you can somewhat easily do so by editing the settings file directly

[eamonburns]

Regarding file format, if you don't want to pull in another dependency for parsing the file, Ghostty went with a very simple key = value format (with comments), with the added feature of every option that can be set in the configuration file can also be set from the command line.

This format could be very nice if all you need are simple key-value pairs (indent-style = space, highlight-current-line = true, color-column = 80)

Key-bindings are a little more tricky, but I think Ghostty handles them pretty well.

keybind = trigger=action

keybind = ctrl+shift+v=select_line

[ES0T]

i would prefer settings not stored in the Windows Registry, if possible.

Windows Terminal has a pretty good settings scheme.

[stianhoiland]

+1 for storing settings in a file. It's the CLI after all!

[peaceshi]

JSON or the KV-like table file maybe the best choice.
and it should be a standard file format or RFC standard.
it should not be a personal preference because the edit will ship with Windows later.