Merged
Conversation
YunchuWang
previously approved these changes
May 22, 2025
The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit updates the extension to retry and still report failed tests. Signed-off-by: Hal Spang <halspang@microsoft.com>
6a836e2 to
351255f
Compare
Signed-off-by: Hal Spang <halspang@microsoft.com>
08c5491 to
e89e1dd
Compare
Signed-off-by: Hal Spang <halspang@microsoft.com>
YunchuWang
approved these changes
Jun 5, 2025
javier-aliaga
pushed a commit
to javier-aliaga/durabletask-java
that referenced
this pull request
Jun 19, 2025
* Fix integration test retry extension The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit removes the customer extension and relies on gradle's built in retry. Signed-off-by: Hal Spang <halspang@microsoft.com>
javier-aliaga
pushed a commit
to javier-aliaga/durabletask-java
that referenced
this pull request
Jul 1, 2025
* Fix integration test retry extension The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit removes the customer extension and relies on gradle's built in retry. Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
pushed a commit
to javier-aliaga/durabletask-java
that referenced
this pull request
Jul 1, 2025
* Fix integration test retry extension The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit removes the customer extension and relies on gradle's built in retry. Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
pushed a commit
to javier-aliaga/durabletask-java
that referenced
this pull request
Jul 4, 2025
* Fix integration test retry extension The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit removes the customer extension and relies on gradle's built in retry. Signed-off-by: Hal Spang <halspang@microsoft.com> Signed-off-by: Javier Aliaga <javier@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit updates the extension to retry and still report failed tests.
CHANGELOG.mdAdditional information
Additional PR information