Disable breaking 1es spotbug task and manage it directly in ci#209
Merged
YunchuWang merged 7 commits intomainfrom Mar 27, 2025
Merged
Disable breaking 1es spotbug task and manage it directly in ci#209YunchuWang merged 7 commits intomainfrom
YunchuWang merged 7 commits intomainfrom
Conversation
This reverts commit 37a7433.
…letask-java into wangbill/spotbug
kaibocai
previously approved these changes
Mar 26, 2025
kaibocai
approved these changes
Mar 26, 2025
JoshVanL
pushed a commit
to JoshVanL/durabletask-java
that referenced
this pull request
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on integrating SpotBugs into the build process for various modules and configuring its settings. The most important changes include adding SpotBugs to the Gradle build files, configuring SpotBugs settings, and updating the CI workflows to include SpotBugs tasks.
Integration of SpotBugs:
.github/workflows/build-validation.yml: Added steps to run SpotBugs and upload its reports during the build process.azurefunctions/build.gradle: Added the SpotBugs plugin and configured its settings, including tool version, effort, report level, and report formats. [1] [2]azuremanaged/build.gradle: Similarly, added the SpotBugs plugin and configured its settings. [1] [2]client/build.gradle: Added the SpotBugs plugin and configured its settings. [1] [2]SpotBugs exclusion filters:
azurefunctions/spotbugs-exclude.xml: Created a filter file to exclude specific classes and patterns from SpotBugs analysis.azuremanaged/spotbugs-exclude.xml: Created a filter file similar to the one forazurefunctions.client/spotbugs-exclude.xml: Created a filter file with additional exclusions for generated protobuf code.CI workflow updates:
eng/ci/official-build.yml: Updated the CI configuration to include SpotBugs settings under the SDL section.Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information