Conversation
cgillum
left a comment
There was a problem hiding this comment.
Is there a PR link for updating the documentation?
| String sendEventPostUri = jsonPath.get("sendEventPostUri"); | ||
| sendEventPostUri = sendEventPostUri.replace("{eventName}", "test"); | ||
| post(sendEventPostUri); | ||
| Thread.sleep(500); |
There was a problem hiding this comment.
We need to do another status check after sending the event to confirm that the orchestration is still in the "Running" state, and that it's not in the "Completed" state.
There was a problem hiding this comment.
I think at the moment when the event is sent, it will still be in the 'Suspended' state, as we don't call to resume the orchestration, and the external event is buffered.
There was a problem hiding this comment.
You're right - it should be "Suspended", not "Running". We should confirm its still in the "Suspended" state after receiving the event.
|
|
||
| String suspendPostUri = jsonPath.get("suspendPostUri"); | ||
| post(suspendPostUri, "Suspend Orchestration"); | ||
| Thread.sleep(500); |
There was a problem hiding this comment.
I wonder if it would be good to increase these sleep values, or to implement polling loops with a maximum period. I'm worried about potential test flakiness if these sleep values are too small.
0bd4ed8 to
a4b93b1
Compare
|
The end2end test shall pass once the extension bundle 4.6.0 is released. Validate the end2end test on local. |
cgillum
left a comment
There was a problem hiding this comment.
LGTM.
Can you open an issue to update the official documentation? https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview
|
Yeah, we already created it here #105 |
Issue describing the changes in this PR
Support resuming and suspending orchestration.
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information
Test on local works fine with DF extension 2.9.3, right now the fully released extension build is 4.4.0 which contains DF extension 2.9.2. Waiting for the next extension bundle fully released then this PR should succeed on CI and can be merged.