Add support for .NET Framework 4.7#19
Merged
Merged
Conversation
…he latest version of the framework
2203064 to
cd47c53
Compare
This was referenced Jun 5, 2017
| Invoke-WebRequest -Uri "https://download.microsoft.com/download/D/D/3/DD35CC25-6E9C-484B-A746-C5BE0C923290/NDP47-KB3186497-x86-x64-AllOS-ENU.exe" \ | ||
| -OutFile C:\NDP47-KB3186497-x86-x64-AllOS-ENU.exe | ||
|
|
||
| RUN ["C:\\NDP47-KB3186497-x86-x64-AllOS-ENU.exe", "/q", "/norestart", "/ChainingPackage", "ADMINDEPLOYMENT"] \ |
Member
There was a problem hiding this comment.
Why multiple layers? It seems inefficient that a layer is getting created that contains the .exe that is getting removed later.
Member
Author
There was a problem hiding this comment.
Oops. I reduced the layers from the original PR but not this one. Not sure why I didn't do that. Thanks.
MichaelSimons
approved these changes
Jun 5, 2017
MichaelSimons
approved these changes
Jun 5, 2017
8447b55 to
d9a3a19
Compare
Member
Author
|
Squashed my commits into one, leaving just the two commits. This means that the commit from @kmcgain will remain in-tact. Will use a merge commit when we land the PR. |
d9a3a19 to
0d9973d
Compare
richlander
added a commit
to microsoft/wcf-docker
that referenced
this pull request
Jun 12, 2017
- Add .NET Framework 4.7 Dockerfile - Update 4.6.2 Dockerfile to FROM dotnet-framework:4.6.2 - Add IIS components directly in place of FROM iis - Dependent on microsoft/dotnet-framework-docker#19 - In support of https://github.com/dotnet/designs/issues/7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.