Add configurable docker container resource limits#359
Open
xingdi-eric-yuan wants to merge 1 commit intomainfrom
Open
Add configurable docker container resource limits#359xingdi-eric-yuan wants to merge 1 commit intomainfrom
xingdi-eric-yuan wants to merge 1 commit intomainfrom
Conversation
…it, cpu_limit)
Add mem_limit, pids_limit, and cpu_limit parameters to DockerTerminal so
downstream users can control container resource constraints via YAML config.
- mem_limit (default: "16G"): container memory limit, unchanged from previous
hardcoded value
- pids_limit (default: 4096): prevents fork bombs and runaway thread creation.
Set to None for unlimited (Docker default)
- cpu_limit (default: None/unlimited): max CPU cores, passed as nano_cpus
All parameters are backward compatible. New defaults preserve existing behavior
except pids_limit which adds a safe default to prevent fork bomb incidents.
Configurable via YAML:
terminal:
type: docker
mem_limit: "32G"
pids_limit: 4096
cpu_limit: 4.0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mem_limit, pids_limit, and cpu_limit parameters to DockerTerminal so downstream users can control container resource constraints via YAML config.
All parameters are backward compatible. New defaults preserve existing behavior except pids_limit which adds a safe default to prevent fork bomb incidents.
Configurable via YAML:
terminal:
type: docker
mem_limit: "32G"
pids_limit: 4096
cpu_limit: 4.0