Fix various build warnings #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylveon
reviewed
Feb 5, 2025
dmachaj
reviewed
Feb 5, 2025
dmachaj
approved these changes
Feb 6, 2025
sylveon
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix a BinSkim issue flagging CFG on prebuild.exe. While I was at it, I fixed a few more warnings. A few were genuine code tweaks, a few were warning suppressions for stuff that's either by design or out of our control.
At this point, the official build pipelines are looking almost 100% clean. Might even be able to enable /WX and cause the build to break on new warnings.