Skip to content

Latest vpack has an extra cppwinrt folder #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DefaultRyan merged 1 commit into from
Nov 8, 2024
Merged

Latest vpack has an extra cppwinrt folder #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pipelines/OneBranch.Official.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ extends:
- task: CopyFiles@2
displayName: 'Stage compiler vpack contents'
inputs:
SourceFolder: $(Build.SourcesDirectory)/x86
SourceFolder: $(Build.SourcesDirectory)/x86/cppwinrt
Copy link
Member

@walbourn walbourn Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be correct to me. If the source is built in $(Build.SourcesDirectory)/x86/cppwinrt then it has to be copied from there.

If what you want is the vpack contents laid out at the root for these files, shouldn't you just have added flattenFolders: true?

Contents: |
cppwinrt/cppwinrt.exe
cppwinrt/cppwinrt.pdb
cppwinrt.exe
cppwinrt.pdb
TargetFolder: $(ob_outputDirectory)

- job: MSBuild_vpack
Expand Down
Loading