Skip to content

Conversation

@sylveon
Copy link
Contributor

@sylveon sylveon commented May 27, 2023

Fixes #1312

@kennykerr kennykerr requested a review from DefaultRyan May 28, 2023 12:48
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@sylveon
Copy link
Contributor Author

sylveon commented Jun 8, 2023

@DefaultRyan can you take a look at this whenever convenient?

@kennykerr
Copy link
Collaborator

The good news is that the OS recently ditched a very very old version of cppwinrt that was only used by Xaml so now there is only one version of cppwinrt in the OS. The bad news is that one newer version is still over a year old, and the later versions introduce build breaks that have thus far prevented updating the OS. Unfortunately, until that is cleared up it won't be easy to update cppwinrt without risking additional delays. Ryan is looking into updating the OS but it may be some time before that's cleared up.

@sylveon
Copy link
Contributor Author

sylveon commented Jun 8, 2023

That sounds like a urge ordeal! Hopefully these get resolved soon. In the meantime, is it possible to prevent the stale bot from closing PRs?

@kennykerr
Copy link
Collaborator

kennykerr commented Jun 8, 2023

I assume you can always reopen the PRs later on if they are closed. And if you just keep commenting on the issue or PR from time to time then it will remain open.

@github-actions
Copy link

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@sylveon
Copy link
Contributor Author

sylveon commented Jun 20, 2023

Bump, waiting on @DefaultRyan's review.

@kennykerr
Copy link
Collaborator

Unfortunately, a project maintainer is not currently available to review this pull request. Please see the contributing guide for more information. Feel free to keep the conversation going on the related issue.

@jonwis
Copy link
Member

jonwis commented Jun 26, 2023

Reopening, will review Monday. Looks great so far.

@jonwis jonwis reopened this Jun 26, 2023
@kennykerr
Copy link
Collaborator

@jonwis - this change is library-only so its relatively simple to review provided good test coverage.

@kennykerr kennykerr requested review from jonwis and removed request for DefaultRyan June 26, 2023 17:12
Copy link
Member

@ChrisGuzak ChrisGuzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I can't think of a problem this would cause.

@jonwis jonwis merged commit 297454e into microsoft:master Jun 27, 2023
@sylveon
Copy link
Contributor Author

sylveon commented Jul 6, 2023

Any chance at a new release with this fix?

@kennykerr
Copy link
Collaborator

Kicked off a build.

@kennykerr
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: weak_ref::get() to an implementation type doesn't compile

4 participants