Add UTF-8 path support #1307
Merged
Add UTF-8 path support #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@alvinhochun any suggestions for the Linux build failure? |
Contributor
Looks like a random unrelated failure in that one test. I suspect a thread left over from another test just happened to interfere with it, perhaps? |
Collaborator
Author
|
Reran and it cleared - thanks for checking. |
oldnewthing
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of a Windows 10 manifest property to set the process code page to UTF-8.
Prior to this update:
With this update:
Input is parsed correctly and output is generated correctly.
I'm reluctant to add a test for this scenario to avoid complicating the build.
Fixes: #1306