Skip to content

Remove explicitly setting PreferredToolArchitecture, since VS 2022 handles this more comprehensively #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scottj1s merged 1 commit into from
May 15, 2023
Merged

Remove explicitly setting PreferredToolArchitecture, since VS 2022 handles this more comprehensively #1304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nuget/Microsoft.Windows.CppWinRT.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ Copyright (C) Microsoft Corporation. All rights reserved.
</PropertyGroup>

<PropertyGroup>
<PreferredToolArchitecture>x64</PreferredToolArchitecture>
Copy link
Contributor

@dmachaj dmachaj May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be scoped to the VS2022 build tools (so that VS2019 still gets it set)?

Copy link
Contributor

@dmachaj dmachaj May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the opposite; only set it for VS2019 and then VS2022+ do not set it because VS does the right thing already.

Copy link
Collaborator

@kennykerr kennykerr May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the latest version of cppwinrt supports the 2019 compiler any longer.

Copy link
Contributor

@dmachaj dmachaj May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nevermind then.

Copy link
Member Author

@Scottj1s Scottj1s May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a bug to set it in VS2019 when building for ARM64 (reported elsewhere). And since it's just a build optimization, I think better to remove it altogether, than to effectively copy the intelligence in the VS 2022 Microsoft.Cpp.ToolsetLocation.props.

<CanReferenceWinRT>true</CanReferenceWinRT>
<CppWinRTPackage Condition="'$(CppWinRTEnabled)' != 'true'">true</CppWinRTPackage>
<CppWinRTPackage Condition="'$(CppWinRTPackage)' != 'true'">false</CppWinRTPackage>
Expand Down