refactor: make Orchestrator implementation details internal#1696
Merged
JamieMagee merged 1 commit intomainfrom Mar 6, 2026
Merged
refactor: make Orchestrator implementation details internal#1696JamieMagee merged 1 commit intomainfrom
JamieMagee merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonpaulos
previously approved these changes
Mar 6, 2026
0bb1f7f to
545a7a2
Compare
Make 8 classes internal in the Orchestrator project: - Converter classes: CommaDelimitedConverter, KeyValueDelimitedConverter, SemicolonDelimitedConverter - CLI helpers: ArgumentHelper, IArgumentHelper - Concrete service implementations: DetectorProcessingService, DetectorRestrictionService, DefaultGraphTranslationService Kept public: ServiceCollectionExtensions, ScanExecutionService, ScanCommand, ScanSettings, LoggingEnricher, DetectorRestrictions, all experiment types, all service interfaces, DetectorRunResult, DetectorProcessingResult. Part of #455
ceb93da to
355692a
Compare
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
jasonpaulos
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make 8 classes
internalin the Orchestrator project.Changes
Converters:
CLI helpers:
Concrete service implementations (interfaces remain public):
IDetectorProcessingServiceIDetectorRestrictionServiceIGraphTranslationServiceKept public
ServiceCollectionExtensions.AddComponentDetection()— primary DI entry pointScanExecutionService/IScanExecutionService— sbom-tool instantiates directlyScanCommand— sbom-tool instantiates directlyScanSettings,BaseSettings,LoggingEnricher,DetectorRestrictionsDetectorRunResult,DetectorProcessingResult— exposed in public interface signaturesStacked on #1695
Part of #455