Skip to content

Handle App Compliance BPF completion when status is Finished but completedon is unset#10917

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-compliance-module-status
Draft

Handle App Compliance BPF completion when status is Finished but completedon is unset#10917
Copilot wants to merge 2 commits intomainfrom
copilot/fix-compliance-module-status

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

In Core v4.50.8, some app compliance reviews remain at Submitted even after analysts finish the BPF in the model-driven UI. The completion flow for apps only transitioned to Complete when completedon was populated, which can miss valid finished transitions.

  • What changed

    • Updated Admin | Compliance request complete apps v3 completion gate to accept either:
      • completedon != null, or
      • statuscode == 2 (Finished) on the App Approval BPF entity.
    • File touched:
      • CenterofExcellenceCoreComponents/SolutionPackage/src/Workflows/AdminCompliancerequestcompleteappsv3-72FB153F-E126-EC11-B6E5-00224822FF33.json
  • Why this resolves the issue

    • The flow now marks admin_apps.admin_adminrequirementriskassessmentstate = 597910003 (Complete) when the BPF is finished even if completedon is not yet present in the trigger payload.
  • Condition update (illustrative)

"expression": {
  "or": [
    { "not": { "equals": ["@triggerOutputs()?['body/completedon']", "@null"] } },
    { "equals": ["@triggerOutputs()?['body/statuscode']", 2] }
  ]
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1022525/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)
  • learn.microsoft.com
    • Triggering command: /usr/bin/curl curl -L --max-time 20 REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[CoE Starter Kit - BUG] ISSUE TITLE</issue_title>
<issue_description>### Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

Hello, we are having a problem with the compliance module. Some non-compliant applications were requested from their makers to provide justifications. However, after receiving the justifications, we finalized the analysis, but the application status remains as "Submitted" instead of "Completed," which is the correct status. Could you help us identify the error or workflow that changes the status to "Completed"?

Even after finalizing the analysis of the justification

Image

The app status remains as Requested

Image

Even when finished, it remains with the "submitted" status.

Image

Expected Behavior

As expected, after completing the justification, the application should display the status "completed".

Image

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.50.8

What app or flow are you having the issue with?

Admin | Compliance request complete apps v3

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

No response

Anything else?

No response</issue_description>

<agent_instructions>Please check what could be the possible reasons for this issue</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Custom agent used: CoE Custom Agent
Specialized agent for triaging and fixing issues in the CoE Starter Kit. Always consult the official CoE docs first, then mine prior GitHub issues and the CoE Common Responses playbook.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: mohamrizwa <220306360+mohamrizwa@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with compliance module application status Handle App Compliance BPF completion when status is Finished but completedon is unset Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CoE Starter Kit - BUG] ISSUE TITLE

2 participants