Conversation
feich-ms
left a comment
There was a problem hiding this comment.
Will this PR align regex_entities in bf-lu luis json with regexEntities in luis api json?
Will this PR align regex_features in bf-lu luis json with regexFeatures in luis api json?
It would be good for you to evaluate/ test this PR for your comparison needs. I want BF-LU to abstract out transform issues and not have this duplicate this everywhere. Can you try and consume this fix, and compare a) LU -> JSON -> in memory LU b) LUIS JSON -> LU and compare them to decide if we should update app version? |
|
|
@vishwacsena I pushed a commit here 1ef2e04. In this commit, I did below changes:
After above changes, the comparison of luis json in lubuild side will be pure like a) LU -> JSON -> in memory LU to compare with b) LUIS JSON -> LU. All other logic are moved to lu side:
After these changes, we can keep any transformation logic in bf-lu side and lu build just consumes this. At last, I added back the phrase list defintions in lu build tests, it works well now. phraselists defintions in lu file are added to each intents automatically just like luis api does. BTW, the failing tests seems caused by changes before this commit. Could you take a look? |
|
@munozemilio fixed PR feedback! can you take a look? Thanks! |
Fixes #675