This repository was archived by the owner on Jan 15, 2025. It is now read-only.
fix luis cross train unable to reference external files #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@munozemilio Hi Emilio, could you help review this PR? This fix an issue reported from a customer. |
munozemilio
reviewed
Apr 14, 2021
munozemilio
suggested changes
Apr 14, 2021
Contributor
munozemilio
left a comment
There was a problem hiding this comment.
Please refactor to avoid code duplication
munozemilio
approved these changes
Apr 20, 2021
munozemilio
added a commit
that referenced
this pull request
Apr 28, 2021
* init * add path resovle * fix import path resolve issue * add tests * fix lint and unused imports * modify config name * retrigger * refactor Co-authored-by: Emilio Munoz <emmunozp@microsoft.com>
munozemilio
added a commit
that referenced
this pull request
Apr 28, 2021
* fix luis cross train unable to reference external files (#1181) * init * add path resovle * fix import path resolve issue * add tests * fix lint and unused imports * modify config name * retrigger * refactor Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * fix luis:build write out version in luis setting when the directVersionPublish is not set (#1215) * init * fix tests * retrigger * remove redundent () * up versioned orchestrator-core to 4.13.1 (#1211) * Update package.json Use orchestrator-core v 4.13.1 * Update pnpm-lock.yaml * skip empty lu file, added empty lu file to test * Update orchestratorhelper.ts fixed lint issues * use forward slash for file path in orchestrator.settings.json to be compatible with non windows platform * addressed PR comments Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * fix luis-cross train does not find imported files with locale (#1209) * fix import file with locale * simplify test * change folder structures * remove only * add cross train config * fix spelling * modify test * change naming * fix readme * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> Co-authored-by: Shuai Wang <shuwan@microsoft.com> Co-authored-by: Tien Suwandy <tiens@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1171
In this fix, as the hierarchy of a project. a.lu and b.qna are able to reference files out side
Appwhen runningbf luis:cross-train -i App -o App/DialogGen --config App/train.config.json --forceIt generated files will include interruptions defined in the external files.