This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Make luis application name comparison case insensitve in luis build#1045
Merged
Make luis application name comparison case insensitve in luis build#1045
Conversation
8 tasks
boydc2014
approved these changes
Nov 5, 2020
Contributor
Author
|
Hi @munozemilio, this is a fix for luis application name case sensitive issue in luis build which was reported by composer team. The root cause is that luis build is not aligned with luis service in application name case sensitivity. To align with luis service whose app name is case insensitive, we changed the comparison logic in luis build to make the app name comparison case insensitive too. Of course, this is just an optimization task instead of a must-have bug fix, but if we get chances to have next planned rc iteration, it will be helpful to include this by the way. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1044 and microsoft/BotFramework-Composer#4627. The fix is to align with luis service to make application name case insensitive in luis build.
App name in luis service is case insensitive, for example, 'my_app_name' and 'My_App_Name' will be treated as same app name. But in current luis build, the name comparison is case sensitive. This PR is trying to make the app name comparison case insensitive in luis build to avoid such inconsistence.
BTW, qna kb name is case sensitive in qnamaker service, so no need to change the comparison logic in qna build.