Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

bf luis:build shouldn't write out version if it's not directVersionPublish #1208

@boydc2014

Description

@boydc2014

Versions

@microsoft/botframework-cli/4.14.0-dev.20210416.ab0fc09 win32-x64 node-v14.15.4

Describe the bug

By default, bf luis:build is not using directVersionPublish, but it writes out version string to dialogs files, which will trigger runtime to regard as "directVersionPublish" and thus try to visit another endpoint and get an 404.

To Reproduce

Run bf luis:build with --dialog files

Expected behavior

If directVersionPublish is false, don't write out version string into luis.settings

[bug]

Metadata

Metadata

Assignees

Labels

P0Must Fix. Release-blockerShipRoom-ApprovedShip room has approved this issue for the release

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions