This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Read Activity Data directly from InputStream#137
Merged
tracyboehrer merged 1 commit intomicrosoft:masterfrom Oct 28, 2019
Merged
Read Activity Data directly from InputStream#137tracyboehrer merged 1 commit intomicrosoft:masterfrom
tracyboehrer merged 1 commit intomicrosoft:masterfrom
Conversation
The input from the bot is marked as content-type "appliation/json; charset=utf-8" even if the charset would not be explicitly stated, RFC8259 requires the encoding to be UTF-8. The approach to read individual bytes from the inputstream and treat each byte as a character (ControllerBase.java) or even as url encoded data (app.java) are just invalid and work by plain luck. If only ascii input is tested, it most probably mostly works, but fails for all inputs with high bytes set. Jackson can decode JSON directly from an inputstream and then does the right thing, there is no need to manually read the stream.
|
|
tracyboehrer
approved these changes
Oct 28, 2019
Member
tracyboehrer
left a comment
There was a problem hiding this comment.
@matthiasblaesing Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input from the bot is marked as content-type "appliation/json; charset=utf-8"
even if the charset would not be explicitly stated, RFC8259 requires the
encoding to be UTF-8.
The approach to read individual bytes from the inputstream and treat
each byte as a character (ControllerBase.java) or even as url encoded
data (app.java) are just invalid and work by plain luck. If only ascii
input is tested, it most probably mostly works, but fails for all inputs
with high bytes set.
Jackson can decode JSON directly from an inputstream and then does the
right thing, there is no need to manually read the stream.