Microsoft open source compliance: policy docs, license, and trademark notice#75
Conversation
Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
…F_CONDUCT.md, CONTRIBUTING.md, and add Trademark Notice to README.md Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
danielmeppiel
left a comment
There was a problem hiding this comment.
@copilot We must not have any url with "https://github.com/danielmeppiel/" in contributing.md.
Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
Removed all |
Co-authored-by: danielmeppiel <51440732+danielmeppiel@users.noreply.github.com>
…workflow Fix CI: Integration Tests venv conflict on ubuntu-24.04
There was a problem hiding this comment.
Pull request overview
This PR updates the repository to comply with Microsoft open source release requirements by replacing several key documentation files with Microsoft standard templates and updating copyright information.
Changes:
- Updated LICENSE copyright holder from "Daniel Meppiel" to "Microsoft Corporation"
- Replaced SECURITY.md with Microsoft's standard security reporting template
- Replaced CODE_OF_CONDUCT.md with Microsoft Open Source Code of Conduct
- Added mandatory Trademarks section to README.md
- Removed hardcoded personal GitHub URLs from CONTRIBUTING.md
- Enhanced scripts/test-integration.sh to handle pre-existing virtual environments in CI
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| LICENSE | Updated copyright holder to Microsoft Corporation |
| SECURITY.md | Replaced with Microsoft standard security reporting template |
| CODE_OF_CONDUCT.md | Replaced with Microsoft Open Source Code of Conduct |
| README.md | Added required Trademarks section per Microsoft guidelines |
| CONTRIBUTING.md | Removed hardcoded danielmeppiel GitHub URLs and replaced with generic placeholders |
| scripts/test-integration.sh | Added logic to check for existing .venv before creating new one (aligns with CI workflow that runs uv sync) |
| # Clone the repository | ||
| git clone https://github.com/danielmeppiel/apm-cli.git | ||
| cd apm-cli | ||
| git clone <this-repo-url> |
There was a problem hiding this comment.
The placeholder <this-repo-url> is too generic and unhelpful for users trying to clone the repository. Consider using a more specific placeholder that indicates the actual repository location, such as https://github.com/microsoft/apm if that's the intended target, or at minimum use a pattern like https://github.com/OWNER/REPO to show the expected URL structure.
| git clone <this-repo-url> | |
| git clone https://github.com/username/apm-cli.git |
| git clone https://github.com/danielmeppiel/apm-cli.git | ||
| cd apm-cli | ||
| git clone <this-repo-url> | ||
| cd apm |
There was a problem hiding this comment.
The directory name change from apm-cli to apm in line 74 is inconsistent with the rest of the repository. Many files still reference apm-cli including pyproject.toml (package name), README.md, CONTRIBUTING.md (title and references), and multiple documentation files. For consistency, this should either remain apm-cli to match the package name, or a comprehensive update should be made across all files to standardize on apm.
| cd apm | |
| cd apm-cli |
…ai-guidelines Microsoft open source compliance: policy docs, license, and trademark notice
🔧 Maintenance
Description
Align repository with Microsoft open source release requirements per docs.opensource.microsoft.com/releasing.
Microsoft Corporationmicrosoft/repo-templates## TrademarkssectiondanielmeppielGitHub URLs — PR template links now reference template names directly, and clone URL uses a generic placeholderType
Testing
Checklist
ignore-for-releaseif not user-facingOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.