Skip to content

.NET: Add CodeQL suppression for DevUI proxy validation - #7505

Merged
SergeyMenshykh merged 1 commit into
microsoft:mainfrom
SergeyMenshykh:fix-codeql-devui-proxy-alert
Aug 5, 2026
Merged

.NET: Add CodeQL suppression for DevUI proxy validation#7505
SergeyMenshykh merged 1 commit into
microsoft:mainfrom
SergeyMenshykh:fix-codeql-devui-proxy-alert

Conversation

@SergeyMenshykh

Copy link
Copy Markdown
Contributor

Adds an inline CodeQL suppression comment for the DevUI aggregator proxy. The proxy target is already validated by ValidateProxyTarget which ensures requests cannot leave the configured backend (host, scheme, and port are verified). The suppression documents this justification following the repo's established pattern.

Copilot AI lite review requested due to automatic review settings August 4, 2026 14:43
@agent-framework-automation agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Aug 4, 2026
@SergeyMenshykh SergeyMenshykh self-assigned this Aug 4, 2026
@SergeyMenshykh SergeyMenshykh moved this to In Review in Agent Framework Aug 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Code Review

Reviewers: 5 | Confidence: 60% | Result: All clear

Reviewed: Correctness, Security Reliability, Test Coverage, Failure Modes, Design Approach


Automated review by SergeyMenshykh's agents

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an inline CodeQL suppression to document why a reported proxy/taint finding is a false positive in the DevUI aggregator proxy path, based on existing target URI validation.

Changes:

  • Adds an inline CodeQL [SM03781] suppression comment on the outbound HttpClient.SendAsync call in the DevUI aggregator proxy.

Comment thread dotnet/src/Aspire.Hosting.AgentFramework.DevUI/DevUIAggregatorHostedService.cs Outdated
The proxy target validation in ValidateProxyTarget already ensures
requests stay on the configured backend. Add an inline suppression
comment following the repo's established pattern.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 4363ab44-4d9e-41a0-97d3-4ab0b973f0b2
@SergeyMenshykh
SergeyMenshykh added this pull request to the merge queue Aug 5, 2026
Merged via the queue into microsoft:main with commit a4d4eaf Aug 5, 2026
25 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in Agent Framework Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants