Python: Fix MCP header provider across transport tasks#6162
Open
kiwigitops wants to merge 1 commit into
Open
Conversation
2943e29 to
6811045
Compare
Signed-off-by: kiwigitops <kiwisclubco@gmail.com>
6811045 to
a0f8bef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4808.
MCPStreamableHTTPToolcurrently stores per-callheader_provideroutput in aContextVarthat the httpx request hook reads later. With the streamable HTTP transport, outbound requests can be sent from a transport task that was created beforecall_tool()set that context, so the hook can see an empty value and skip the dynamic headers.This keeps the active headers on the tool instance for the duration of the tool call, so the existing request hook reads the current header snapshot even when the transport sends from another task. The previous value is restored after the call completes.
Tested:
python -m pytest python/packages/core/tests/core/test_mcp.py -k header_provider -qpython -m ruff check python/packages/core/agent_framework/_mcp.py python/packages/core/tests/core/test_mcp.pygit diff --check