Remove UserInputRequests methods - #70
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the UserInputRequests() methods from the Message, Response, ResponseUpdate, and Contents types, replacing them with a more generic Contents() method on the Response type. The motivation is to simplify the API, as demonstrated by the updated examples and alignment with the .NET implementation.
Changes:
- Removed filtering helper methods (
UserInputRequests()) that only returnedFunctionApprovalRequestContentitems - Added a generic
Contents()method on Response that returns all content types - Updated example code to iterate over all contents and filter for the desired type
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| message/content.go | Removed UserInputRequests() method from Contents type and unused iter import |
| message/message.go | Removed UserInputRequests() from Message and ResponseUpdate; added generic Contents() method to Response |
| examples/getting_started/azure_openai/step04_using_function_tools_with_approvals/main.go | Updated to use Contents() instead of UserInputRequests() |
| examples/getting_started/agent/step04_using_function_tools_with_approvals/main.go | Updated to use Contents() instead of UserInputRequests() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gdams
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't add any value, as demonstrated by the examples changes in this PR. .NET just remove it in microsoft/agent-framework#3682.