[dotnet-port] Port auto-approval rules (heuristics) to toolapproval middleware

[qmuntal]

Port microsoft/agent-framework#6335: add heuristic auto-approval rules to ToolApprovalAgent. AutoApprovalRules in Config lets callers provide callbacks that are evaluated after standing rules but before surfacing an approval request to the user. The first rule returning approved=true auto-approves the call without interrupting the caller; if a rule returns an error, the run fails with that error.

• Add AutoApprovalRules []func(context.Context, *message.FunctionCallContent) (bool, error) to Config
• Change New to capture cfg via closure instead of ignoring it
• Change run to accept Config and thread it through to drainAutoApprovable
• Add matchesAutoApprovalRules helper (first-match-wins semantics, nil entries skipped, error propagation)
• Apply auto-approval rules in drainAutoApprovable (queued requests) and in the outbound classification loop (new requests from inner agent)
• Propagate auto-approval rule errors from both queued-drain and classification paths
• Update tests and docs to reflect AutoApprovalRules naming and context-aware callback signature with error return

[Copilot]

Pull request overview

This PR ports heuristic auto-approval support into the Go agent/harness/toolapproval middleware, allowing callers to provide custom predicate functions (AutoApprovalFuncs) that can auto-approve tool calls after standing rules but before surfacing approval requests to the caller.

Changes:

• Adds Config.AutoApprovalFuncs []func(*message.FunctionCallContent) bool and threads Config through the middleware run loop.
• Applies heuristic auto-approval both when draining queued requests and when classifying newly emitted approval requests.
• Updates docs and adds tests for basic matching/non-matching and ordering semantics.

Show a summary per file

File	Description
docs/dotnet-go-sdk-feature-comparison.md	Updates the feature matrix to mention auto-approval heuristics for tool approval.
agent/harness/toolapproval/toolapproval.go	Introduces AutoApprovalFuncs config and applies it in queued draining + outbound request classification.
agent/harness/toolapproval/toolapproval_test.go	Adds tests covering auto-approval func behavior and ordering; includes a test naming/coverage gap around standing-rule precedence.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 4

[qmuntal]

@copilot fix #254 (comment)

[Copilot]

@copilot fix #254 (comment)

Implemented in 0817fc9.

• Clarified toolapproval.Config.AutoApprovalFuncs docs to state callbacks are synchronous and should be fast/non-blocking.
• Updated the SDK comparison table to use toolapproval.Config{...} and explicitly note Go uses AutoApprovalFuncs while .NET uses AutoApprovalRules.

[qmuntal]

@copilot rename AutoApprovalFuncs to AutoApprovalRules and make the callback accept a context.Context. Undo 0817fc9.

[Copilot]

@copilot rename AutoApprovalFuncs to AutoApprovalRules and make the callback accept a context.Context. Undo 0817fc9...

Implemented in fd446e7 (API change) and d63a91d (follow-up terminology cleanup).

• Renamed toolapproval.Config.AutoApprovalFuncs to AutoApprovalRules.
• Updated callback signature to func(context.Context, *message.FunctionCallContent) bool and threaded context.Context through auto-approval evaluation paths.
• Undid commit 0817fc9 changes and updated docs/tests to reflect the new API.

[qmuntal]

@copilot AutoApprovalRules callbacks return signature should also have an error.

[Copilot]

@copilot AutoApprovalRules callbacks return signature should also have an error.

Implemented in 79eb87b.

AutoApprovalRules callbacks now use func(context.Context, *message.FunctionCallContent) (bool, error). Middleware now propagates callback errors (including queued-request draining and outbound classification), and tests were updated to the new signature with coverage for the error path.

[github-actions]

Cross-Repo Parity Review

This PR ports AutoApprovalRules from the upstream .NET ToolApprovalAgentOptions (dotnet/src/Microsoft.Agents.AI/Harness/ToolApproval/ToolApprovalAgentOptions.cs) faithfully. ✅

API shape comparison

Aspect	.NET	Go (this PR)
Rule signature	Func<FunctionCallContent, ValueTask<bool>>	func(context.Context, *message.FunctionCallContent) (bool, error)
Cancellation	None (no CancellationToken)	context.Context (idiomatic Go)
Error propagation	Exception bubbling	Explicit error return (idiomatic Go)
Nil/null rules	Not guarded	Nil entries skipped (defensive Go pattern)
Evaluation order	After standing rules, first-match-wins	Same ✅
Queued-request drain	Applies rules to queued requests	Same ✅
Error fails run	Exception unwinds run	err != nil yields error and returns ✅

Verdict

The Go implementation is semantically aligned with the upstream .NET implementation. The differences (context.Context added, error return instead of exception) are idiomatic language adaptations rather than behavioral divergences. No cross-repo parity concerns.

Generated by Go API Consistency Review Agent for issue #254 · ● 6M · ◷