Fix serialization of accessor types in declaration files.#61392
Merged
weswigham merged 1 commit intomicrosoft:mainfrom Mar 14, 2025
Merged
Fix serialization of accessor types in declaration files.#61392weswigham merged 1 commit intomicrosoft:mainfrom
weswigham merged 1 commit intomicrosoft:mainfrom
Conversation
weswigham
approved these changes
Mar 14, 2025
Member
weswigham
left a comment
There was a problem hiding this comment.
I feel like there's probably still some more places where we're doing some unchecked/uninstantiated node retention - particularly locations in the syntactic builder which prefer uses of canReuseTypeNode over canReuseTypeNodeAnnotation, as the former lacks a bunch of context with which to do sanity checking via a typeNodeIsEquivalentToType call, but this is a definite improvement.
Member
|
@typescript-bot cherry-pick this to release-5.8 |
Collaborator
typescript-bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
Collaborator
|
Hey, @jakebailey! I've created #61423 for you. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 19, 2025
…e-5.8 (#61423) Co-authored-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61338
Fixes #61391