Make builder not depend on information from dts emit about really needed modules#57800
Merged
sheetalkamat merged 3 commits intomainfrom Mar 18, 2024
Merged
Make builder not depend on information from dts emit about really needed modules#57800sheetalkamat merged 3 commits intomainfrom
sheetalkamat merged 3 commits intomainfrom
Conversation
…ause of false possitives from check file.signagure === file.version
…ot depending on d.ts having iterated over all symbols to find really needed module imports/type references etc
…fo from d.ts emit
Member
|
Just so I understand, is this cleanup a net negative? Or is it fine? |
Member
Author
|
With this change we may refresh diagnostics and d.ts emit for more files depending on if dts emit uses subset of ts file imports or all of them. But with upcoming change of not writing references, type refs etc this is kind of needed if that goes in, |
jakebailey
approved these changes
Mar 18, 2024
Member
jakebailey
left a comment
There was a problem hiding this comment.
Seems alright to me, then. Thanks for looking into this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier we use to use information from d.ts emit about all the module symbols that the file used so we could only mark subset of actual import/references etc to invalidate semantic diagnostics and d.ts emit for.
Given that d.ts emit is changing, we cant deterministically get this information any more so we have to invalidate it for all references
This removes use of exportMap from builder and buildInfo
8d3a02f Is just test update that fixes the incorrect information about signature (marks as version use even though it computed signature if signature and version are same)
dcdc654 actual change of not depending on
exportedModulesFromDeclarationEmitand baselines that only change buildInfo to removeexportsMapentry7b29ccb are all baselines that got updated because of using extra set of files to invalidate.
Precursor for #57681