Report grammar errors for invalid decorator grammar by rbuckton · Pull Request #57749 · microsoft/TypeScript

rbuckton · 2024-03-12T18:31:32Z

This reports a grammar error when invalid syntax is used in a decorator expression that does not match the proposed syntax for Stage 3 Decorators. In addition, this adds quick fixes to add parentheses around the expression to make it valid.

This is a somewhat aggressive error as we previously were far more flexible for decorator expressions under --experimentalDecorators, which could mean new errors reported in existing code. Since parse and emit do not change, and since there is a quick-fix available, I'd like to try to go ahead with this change as is. However, if we feel it is too much of break, I can change the grammar check to only apply when targeting ES decorators.

Fixes #55336

jakebailey · 2024-03-12T18:33:57Z

@typescript-bot test top400
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this faster
@typescript-bot pack this

typescript-bot · 2024-03-12T18:34:00Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-03-12T18:38:50Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160317/artifacts?artifactName=tgz&fileId=7078521EA8FE0E59B92E23275A8C67308DE31F636FF34B76148571F54C2FB85402&fileName=/typescript-5.5.0-insiders.20240312.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-57749-2".;

typescript-bot · 2024-03-12T18:53:49Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/57749/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-03-12T18:54:30Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-03-12T19:43:31Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,599k (± 0.01%)}	_{295,602k (± 0.01%)}	_~	_295,566k	_295,626k	_{p=0.689 n=6}
_{Parse Time}	_{2.66s (± 0.15%)}	_{2.66s (± 0.24%)}	_~	_2.65s	_2.67s	_{p=0.673 n=6}
_{Bind Time}	_{0.83s (± 1.08%)}	_{0.83s (± 0.99%)}	_~	_0.82s	_0.84s	_{p=0.550 n=6}
_{Check Time}	_{8.21s (± 0.27%)}	_{8.21s (± 0.34%)}	_~	_8.17s	_8.24s	_{p=0.625 n=6}
_{Emit Time}	_{7.15s (± 0.50%)}	_{7.13s (± 0.39%)}	_~	_7.08s	_7.15s	_{p=0.288 n=6}
_{Total Time}	_{18.85s (± 0.27%)}	_{18.83s (± 0.24%)}	_~	_18.78s	_18.89s	_{p=0.747 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,787k (± 0.94%)}	_{193,308k (± 0.93%)}	_~	_191,422k	_195,121k	_{p=0.810 n=6}
_{Parse Time}	_{1.35s (± 1.01%)}	_{1.36s (± 1.14%)}	_~	_1.35s	_1.39s	_{p=0.800 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.28s (± 0.22%)}	_{9.32s (± 0.48%)}	_~	_9.28s	_9.38s	_{p=0.053 n=6}
_{Emit Time}	_{2.60s (± 0.53%)}	_{2.61s (± 0.86%)}	_~	_2.59s	_2.65s	_{p=0.867 n=6}
_{Total Time}	_{13.96s (± 0.20%)}	_{14.01s (± 0.47%)}	_~	_13.94s	_14.10s	_{p=0.107 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,332k (± 0.00%)}	_{347,343k (± 0.01%)}	_~	_347,316k	_347,382k	_{p=0.810 n=6}
_{Parse Time}	_{2.49s (± 0.16%)}	_{2.49s (± 0.34%)}	_~	_2.47s	_2.49s	_{p=0.527 n=6}
_{Bind Time}	_{0.92s (± 0.59%)}	_{0.93s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=0.282 n=6}
_{Check Time}	_{6.95s (± 0.28%)}	_{6.96s (± 0.20%)}	_~	_6.94s	_6.98s	_{p=0.222 n=6}
_{Emit Time}	_{4.08s (± 0.55%)}	_{4.06s (± 0.40%)}	_~	_4.04s	_4.08s	_{p=0.142 n=6}
_{Total Time}	_{14.44s (± 0.26%)}	_{14.43s (± 0.24%)}	_~	_14.38s	_14.47s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,764k (± 0.01%)}	_{302,761k (± 0.01%)}	_~	_302,724k	_302,786k	_{p=0.936 n=6}
_{Parse Time}	_{2.02s (± 0.79%)}	_{2.01s (± 0.96%)}	_~	_1.98s	_2.03s	_{p=0.560 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.00s (± 0.63%)}	_~	_0.99s	_1.01s	_{p=0.654 n=6}
_{Check Time}	_{6.33s (± 0.31%)}	_{6.32s (± 0.49%)}	_~	_6.29s	_6.37s	_{p=0.570 n=6}
_{Emit Time}	_{3.60s (± 0.23%)}	_{3.61s (± 0.48%)}	_~	_3.59s	_3.63s	_{p=0.134 n=6}
_{Total Time}	_{12.95s (± 0.33%)}	_{12.94s (± 0.28%)}	_~	_12.87s	_12.97s	_{p=0.803 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,265k (± 0.01%)}	_{511,254k (± 0.01%)}	_~	_511,212k	_511,310k	_{p=0.689 n=6}
_{Parse Time}	_{2.66s (± 0.37%)}	_{2.66s (± 0.39%)}	_~	_2.64s	_2.67s	_{p=0.788 n=6}
_{Bind Time}	_{0.98s (± 0.85%)}	_{0.97s (± 1.41%)}	_~	_0.95s	_0.99s	_{p=0.210 n=6}
_{Check Time}	_{17.32s (± 0.23%)}	_{17.29s (± 0.40%)}	_~	_17.19s	_17.37s	_{p=0.746 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.16%)}	_{20.93s (± 0.31%)}	_~	_20.82s	_20.98s	_{p=0.687 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,789,413k (± 0.00%)}	_{1,789,404k (± 0.00%)}	_~	_1,789,369k	_1,789,453k	_{p=0.575 n=6}
_{Parse Time}	_{6.63s (± 0.25%)}	_{6.63s (± 0.52%)}	_~	_6.61s	_6.70s	_{p=0.681 n=6}
_{Bind Time}	_{2.39s (± 0.26%)}	_{2.39s (± 0.49%)}	_~	_2.38s	_2.41s	_{p=1.000 n=6}
_{Check Time}	_{58.97s (± 0.36%)}	_{58.94s (± 0.34%)}	_~	_58.78s	_59.30s	_{p=0.810 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.16s (± 2.52%)}	_~	_0.16s	_0.17s	_{p=0.595 n=6}
_{Total Time}	_{68.14s (± 0.32%)}	_{68.12s (± 0.31%)}	_~	_67.94s	_68.47s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,395,362k (± 0.01%)}	_{2,395,399k (± 0.03%)}	_~	_2,394,342k	_2,396,222k	_{p=0.936 n=6}
_{Parse Time}	_{5.08s (± 0.89%)}	_{5.07s (± 1.21%)}	_~	_4.97s	_5.13s	_{p=0.936 n=6}
_{Bind Time}	_{1.89s (± 0.64%)}	_{1.90s (± 0.70%)}	_~	_1.88s	_1.91s	_{p=0.507 n=6}
_{Check Time}	_{33.58s (± 0.25%)}	_{33.62s (± 0.32%)}	_~	_33.47s	_33.76s	_{p=0.376 n=6}
_{Emit Time}	_{2.67s (± 1.21%)}	_{2.68s (± 0.94%)}	_~	_2.64s	_2.71s	_{p=0.689 n=6}
_{Total Time}	_{43.24s (± 0.18%)}	_{43.29s (± 0.28%)}	_~	_43.14s	_43.51s	_{p=0.470 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,595k (± 0.01%)}	_{414,684k (± 0.01%)}	_{+89k (+ 0.02%)}	_414,638k	_414,721k	_{p=0.005 n=6}
_{Parse Time}	_{2.81s (± 0.77%)}	_{2.82s (± 0.91%)}	_~	_2.78s	_2.86s	_{p=0.466 n=6}
_{Bind Time}	_{1.06s (± 0.49%)}	_{1.06s (± 0.71%)}	_~	_1.05s	_1.07s	_{p=0.784 n=6}
_{Check Time}	_{15.15s (± 0.32%)}	_{15.18s (± 0.27%)}	_~	_15.13s	_15.24s	_{p=0.260 n=6}
_{Emit Time}	_{1.12s (± 1.26%)}	_{1.13s (± 1.04%)}	_~	_1.12s	_1.15s	_{p=0.357 n=6}
_{Total Time}	_{20.15s (± 0.19%)}	_{20.19s (± 0.25%)}	_~	_20.13s	_20.25s	_{p=0.148 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,868,527k (± 0.00%)}	_{2,868,526k (± 0.00%)}	_~	_2,868,465k	_2,868,591k	_{p=1.000 n=6}
_{Parse Time}	_{10.77s (± 0.14%)}	_{10.77s (± 0.17%)}	_~	_10.75s	_10.80s	_{p=0.807 n=6}
_{Bind Time}	_{3.45s (± 0.37%)}	_{3.45s (± 0.63%)}	_~	_3.42s	_3.48s	_{p=1.000 n=6}
_{Check Time}	_{60.91s (± 0.33%)}	_{60.82s (± 0.40%)}	_~	_60.49s	_61.16s	_{p=0.630 n=6}
_{Emit Time}	_{16.33s (± 0.51%)}	_{16.34s (± 0.36%)}	_~	_16.29s	_16.45s	_{p=0.936 n=6}
_{Total Time}	_{91.46s (± 0.20%)}	_{91.39s (± 0.31%)}	_~	_91.08s	_91.75s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{404,894k (± 0.01%)}	_{404,877k (± 0.02%)}	_~	_404,799k	_405,010k	_{p=0.298 n=6}
_{Parse Time}	_{3.24s (± 0.49%)}	_{3.25s (± 0.34%)}	_~	_3.23s	_3.26s	_{p=0.280 n=6}
_{Bind Time}	_{1.39s (± 0.76%)}	_{1.40s (± 1.63%)}	_~	_1.38s	_1.44s	_{p=0.250 n=6}
_{Check Time}	_{14.09s (± 0.16%)}	_{14.07s (± 0.35%)}	_~	_14.00s	_14.13s	_{p=0.459 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.72s (± 0.14%)}	_{18.72s (± 0.27%)}	_~	_18.64s	_18.77s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,150k (± 0.01%)}	_{513,196k (± 0.01%)}	_~	_513,154k	_513,267k	_{p=0.078 n=6}
_{Parse Time}	_{3.27s (± 0.32%)}	_{3.27s (± 0.36%)}	_~	_3.26s	_3.29s	_{p=0.619 n=6}
_{Bind Time}	_{1.54s (± 0.49%)}	_{1.54s (± 0.34%)}	_~	_1.53s	_1.54s	_{p=0.784 n=6}
_{Check Time}	_{2.86s (± 0.82%)}	_{2.86s (± 0.53%)}	_~	_2.85s	_2.88s	_{p=0.935 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.76s (± 0.46%)}	_{7.75s (± 0.16%)}	_~	_7.74s	_7.77s	_{p=0.625 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-03-12T19:58:08Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57749/merge:

Everything looks good!

weswigham

Should we also test @import.meta.decorator, since we have tests for super and this?

jakebailey · 2024-03-12T20:41:32Z

All of the user / top tests seem to be okay with this, which is good news.

rbuckton · 2024-03-12T21:01:26Z

Should we also test @import.meta.decorator, since we have tests for super and this?

I'm not sure why we would. Those tests specifically test which this is in scope.

rbuckton · 2024-03-12T21:01:52Z

@typescript-bot pack this

typescript-bot · 2024-03-12T21:01:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-03-12T21:06:50Z

Hey @rbuckton, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160330/artifacts?artifactName=tgz&fileId=7D1FCABBA39743080FCFCD40B8981DDBE7F6538EB6E6517B682DA7FDF8AD76F102&fileName=/typescript-5.5.0-insiders.20240312.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-57749-11".;

ef4 · 2024-07-05T23:19:07Z

However, if we feel it is too much of break, I can change the grammar check to only apply when targeting ES decorators.

That would be a lot better, speaking as a framework maintainer that's trying to help shepherd a big ecosystem of community maintained code across the migration from experimental decorators to stage3 decorators. As experimental decorators are clearly an end-of-the-road feature that's maintained only for compatibility, anything you can do to not destabilize them unnecessarily would be helpful.

StNekroman · 2025-09-24T13:48:45Z

Why this touches legacy experimental decorators , despite PR's description was about "Stage 3 Decorators" ?
Any good reason for breaking backward compatibility?

Report grammar errors for invalid decorator grammar

27f6ca2

rbuckton requested review from DanielRosenwasser, andrewbranch, jakebailey and weswigham March 12, 2024 18:31

typescript-bot assigned rbuckton Mar 12, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 12, 2024

Formatting

332aadf

weswigham approved these changes Mar 12, 2024

View reviewed changes

DanielRosenwasser mentioned this pull request Mar 12, 2024

Design Meeting Notes, 3/12/2024 #57756

Closed

Additional tests

3526677

andrewbranch approved these changes Mar 13, 2024

View reviewed changes

rbuckton merged commit 5e8f900 into main Mar 13, 2024

rbuckton deleted the fix-55336-decorator-grammar branch March 13, 2024 18:50

Conversation

rbuckton commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Mar 12, 2024

Uh oh!

typescript-bot commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 12, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

typescript-bot commented Mar 12, 2024

Uh oh!

typescript-bot commented Mar 12, 2024

tsc

Uh oh!

typescript-bot commented Mar 12, 2024

Uh oh!

weswigham left a comment

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Mar 12, 2024

Uh oh!

rbuckton commented Mar 12, 2024

Uh oh!

rbuckton commented Mar 12, 2024

Uh oh!

typescript-bot commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ef4 commented Jul 5, 2024

Uh oh!

StNekroman commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rbuckton commented Mar 12, 2024 •

edited

Loading

typescript-bot commented Mar 12, 2024 •

edited

Loading

typescript-bot commented Mar 12, 2024 •

edited

Loading

typescript-bot commented Mar 12, 2024 •

edited

Loading

typescript-bot commented Mar 12, 2024 •

edited

Loading

StNekroman commented Sep 24, 2025 •

edited

Loading