Add union of replacer function and string #34941
Closed
marcin-serwin wants to merge 2 commits intomicrosoft:masterfrom
marcin-serwin:master
Closed
Add union of replacer function and string #34941marcin-serwin wants to merge 2 commits intomicrosoft:masterfrom marcin-serwin:master
marcin-serwin wants to merge 2 commits intomicrosoft:masterfrom
marcin-serwin:master
Conversation
Contributor
|
Hi @marcin-serwin - this PR didn't have 'allow maintainers to make changes' checked, and so when we migrated TypeScript's primary branch from 'master' to 'main' this PR couldn't have its branch re-targeted. It looks like we've not quite pushed this PR over the line (IMO, that's on us the TypeScript team, not you) - I'm running the tests on a new PR which replicates your work and is up-to-date. Will link that to this when that's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29789