Hoisted declarations should occur after prologue directives #24386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
May 24, 2018
Contributor
|
Please port to release-2.9 as well. |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
May 24, 2018
mhegazy
added a commit
that referenced
this pull request
May 24, 2018
Hoisted declarations should occur after prologue directives (#24386)
ajafff
reviewed
May 25, 2018
| export function prependStatements<T extends Statement>(to: T[], from: ReadonlyArray<T> | undefined): T[] | undefined { | ||
| if (from === undefined || from.length === 0) return to; | ||
| if (to === undefined) return from.slice(); | ||
| const prologue = to.length && isPrologueDirective(to[0]) && to.shift(); |
Contributor
There was a problem hiding this comment.
It's possible that there is more than one directive. Though I don't know if that occurs in real world code. Should this case be handled here?
Member
Author
There was a problem hiding this comment.
We don't handle it in any other locations we check for prologues, I looked. I figured I shouldn't differ here.
This was referenced Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a break I noticed in our RWC suite.