Instead of creating clone of the jsxFactory's leaf node, create synthesized node#12475
Merged
sheetalkamat merged 1 commit intomasterfrom Nov 23, 2016
Merged
Instead of creating clone of the jsxFactory's leaf node, create synthesized node#12475sheetalkamat merged 1 commit intomasterfrom
sheetalkamat merged 1 commit intomasterfrom
Conversation
…esized node Fixes #12467 This avoid setting original node which would be something from isolated parsing and hence not valid when resolving expression
mhegazy
approved these changes
Nov 23, 2016
Contributor
|
Can you port this to release-2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoid setting original node which would be something from isolated parsing and hence not valid when resolving expression
Fixes #12467