This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Generate MacOS arm64 CLI binary in addition to x64 binary#464
Merged
jdubois merged 2 commits intomicrosoft:mainfrom Oct 6, 2023
Merged
Generate MacOS arm64 CLI binary in addition to x64 binary#464jdubois merged 2 commits intomicrosoft:mainfrom
jdubois merged 2 commits intomicrosoft:mainfrom
Conversation
- Keeping backward compatible binary name for x64 - Using `macos-latest-xlarge` runner for arm64
f174d68 to
1965cb1
Compare
jdubois
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #460
Github just released a new Apple Silicon M1 runner we can use to compile natively to
arm64:https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/
This PR adds the
macos-latest-xlargerunner to the matrix which compiles anarm64binary that can natively be run on Apple Silicon without Rosetta.It keeps the previous binary name
nubesgen-cli-macosfor x64 and introduces the newnubesgen-cli-macos-arm64binary name for Apple Silicon.