This repository was archived by the owner on Mar 21, 2024. It is now read-only.
ENH: Add Environment Locking#735
Merged
Merged
Conversation
87db758 to
752946a
Compare
752946a to
76f4da4
Compare
ant0nsc
suggested changes
May 30, 2022
ant0nsc
left a comment
Contributor
There was a problem hiding this comment.
Two sections are still empty. Also, something wrong there with "environment_win.yml", it is marked as a binary file in the UI??
ant0nsc
approved these changes
May 30, 2022
ant0nsc
left a comment
Contributor
There was a problem hiding this comment.
Looking great! 2 minor things:
- please add a "do not edit" comment in both locked environments
- change the PR title to remove the "proof-of-concept" thing
117fed7 to
ab1f606
Compare
fepegar
reviewed
May 31, 2022
fepegar
suggested changes
May 31, 2022
fepegar
approved these changes
Jun 1, 2022
fepegar
left a comment
Contributor
There was a problem hiding this comment.
Approved with some minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #726
This includes changes to how we handle primary and secondary dependencies in the InnerEye Deep Learning library. Locking is now performed through the use of
conda export, preventing secondary versions from switching unexpectedly. Through the use of a bash script the env is locked and anenvironment.ymlsuitable for ingestion by AzureML is constructed.This is far from a perfect solution, but at the very least significantly reduces the chance of pipelines failing due to secondary dependency version changes.