This repository was archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 145
Ensure the shape of input patches is compatible with model constraints #682
Merged
fepegar
merged 10 commits into
microsoft:main
from
fepegar:ensure-patches-shape-multiple
Mar 10, 2022
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fade6c3
Ensure patches shape is compatible with model constraints
fepegar e1354ac
Ignore mypy error
fepegar d47538b
Use TorchIO transform only when constraints are not None
fepegar f4c6634
Ignore yet another mypy error
fepegar 29e62e0
Remove test for images that are too small
fepegar 5444b89
Merge branch 'main' into ensure-patches-shape-multiple
fepegar 21d35f6
Merge branch 'main' into ensure-patches-shape-multiple
fepegar f6ae8a5
Merge branch 'main' into ensure-patches-shape-multiple
fepegar 6e10e63
Merge branch 'main' into ensure-patches-shape-multiple
fepegar aa0d43e
Merge branch 'main' into ensure-patches-shape-multiple
fepegar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because images will never be too small after merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other PR does not have tests. Is it not possible to have a test to demonstrate that this is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe all this is covered by the tests in https://github.com/microsoft/InnerEye-DeepLearning/blob/main/Tests/ML/models/architectures/test_crop_size_multiple.py