This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Replace RadIO with TorchIO for patch-based inference#666
Merged
Conversation
2aaf96b to
201ed00
Compare
Contributor
Author
|
I "fixed" some mypy errors by explicitly ignoring them. I'm not sure this is the best solution. |
ant0nsc
approved these changes
Feb 21, 2022
ant0nsc
left a comment
Contributor
There was a problem hiding this comment.
Looking GREAT! Lots of ugly code replaced by uncle tio ;-)
javier-alvarez
suggested changes
Feb 22, 2022
javier-alvarez
left a comment
Contributor
There was a problem hiding this comment.
#665 Lets address this one before merging and run manual regression test on prostate and H&N
Contributor
Author
Comparison RadIO vs TorchIOI suspect the tiny differences might be due to implementation details. For example, if an image needs to be 3 voxels larger along a specific dimensions, we could add 2 voxels at the beginning and 1 at the end, or vice versa. QuantitativeRadIO
TorchIO
Qualitative |
Contributor
Author
|
I can run H&N too, but I suspect results will be very similar again. |
javier-alvarez
approved these changes
Feb 22, 2022
This was referenced Feb 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Write a detailed description of your PR here.
Please follow the guidelines for PRs contained here. Checklist:
Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.