This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Enable fine-tuning in Deepmil#650
Merged
Merged
Conversation
ant0nsc
previously approved these changes
Feb 3, 2022
ant0nsc
left a comment
Contributor
There was a problem hiding this comment.
Code looks good - but do we have any way of testing it?
dccastro
reviewed
Feb 3, 2022
dccastro
reviewed
Feb 3, 2022
added 3 commits
February 3, 2022 15:17
…ft/InnerEye-DeepLearning into hsharma/pandahistosslmil
added 2 commits
February 4, 2022 14:02
vale-salvatelli
left a comment
Contributor
There was a problem hiding this comment.
As discussed I think we need to make this more robust:
- makes sure it can run on multi-gpu and doesn't hit memory errors
- adding tests
But I am happy to approve as first version so that more people can help out
vale-salvatelli
previously approved these changes
Feb 8, 2022
dccastro
approved these changes
Feb 9, 2022
| histossl_encoder.fc = torch.nn.Sequential() | ||
| for param in histossl_encoder.parameters(): | ||
| param.requires_grad = False | ||
| return histossl_encoder, num_features # type: ignore |
Member
There was a problem hiding this comment.
Minor suggestion to revert these changes in _get_encoder(), as setup_feature_extractor() now implements the same behaviour.
vale-salvatelli
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following: